Re: [PATCH] m68k/mac: Fix macintosh_config for Mac II

From: Geert Uytterhoeven
Date: Thu Apr 24 2025 - 03:32:58 EST


On Thu, 24 Apr 2025 at 02:13, Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
> When booted on my Mac II, the kernel prints this:
>
> Detected Macintosh model: 6
> Apple Macintosh Unknown
>
> The catch-all entry ("Unknown") is mac_data_table[0] which is only needed
> in the unlikely event that the bootinfo model ID can't be matched.
> When model ID is 6, the search should begin and end at mac_data_table[1].
> Fix the off-by-one error that causes this problem.
>
> Cc: Joshua Thompson <funaho@xxxxxxxxx>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>

Nice catch!

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k tree for v6.16.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds