Re: [PATCH v2] cgroup: Fix compilation issue due to cgroup_mutex not being exported

[Kamalesh Babulal]

Hi,

On 4/18/25 8:12 AM, gaoxu wrote:

[...]
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 447ac857e..c1bc51058 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -84,13 +84,13 @@
>   * css_set_lock protects task->cgroups pointer, the list of css_set
>   * objects, and the chain of tasks off each css_set.
>   *
> - * These locks are exported if CONFIG_PROVE_RCU so that accessors in
> - * cgroup.h can use them for lockdep annotations.
> + * These locks are exported if CONFIG_PROVE_RCU or CONFIG_LOCKDEP so that
> + * accessors in cgroup.h can use them for lockdep annotations.
>   */

Tejun has already merged the initial version of the patch without
the updated description. You may want to send the description change
as a separate patch, rebased on top of the cgroup/for-next branch.

I've rephrased the description to clarify that lockdep annotations
can occur even without CONFIG_PROVE_RCU. Feel free to use this
version or modify it further:
"Export locks for lockdep annotations. Use CONFIG_PROVE_RCU for
accessors in cgroup.h, and CONFIG_LOCKDEP for accessors that do not
require CONFIG_PROVE_RCU."

-- 
Cheers,
Kamalesh