Re: [PATCH v2 2/3] configfs: Do not override creating attribute file failure in populate_attrs()
From: Breno Leitao
Date: Thu Apr 17 2025 - 10:57:28 EST
On Tue, Apr 15, 2025 at 08:34:26PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
>
> populate_attrs() may override failure for creating attribute files
> by success for creating subsequent bin attribute files, and have
> wrong return value.
>
> Fix by creating bin attribute files under successfully creating
> attribute files.
>
> Fixes: 03607ace807b ("configfs: implement binary attributes")
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Joel Becker <jlbec@xxxxxxxxxxxx>
> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>