Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support
From: Krzysztof Kozlowski
Date: Thu Apr 17 2025 - 02:18:59 EST
On 15/04/2025 09:27, Peter Chen wrote:
> +
> + mbox_ap2pm: mailbox@6590080 {
> + compatible = "cix,sky1-mbox";
> + reg = <0x0 0x06590080 0x0 0xff80>;
> + interrupts = <GIC_SPI 363 IRQ_TYPE_LEVEL_HIGH 0>;
> + #mbox-cells = <1>;
> + cix,mbox-dir = "tx";
> + };
> +
> + pm2ap_scmi_mem: pm2ap-shmem@65a0000 {
> + compatible = "arm,scmi-shmem";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + reg-io-width = <4>;
> + reg = <0x0 0x065a0000 0x0 0x80>;
Messed order of properties. Keep it consistent (see DTS conding style).
Other nodes also have oddly placed reg.
Best regards,
Krzysztof