Re: [PATCH v3 net-next 2/8] dt-bindings: dpll: Add support for Microchip Azurite chip family

From: Krzysztof Kozlowski
Date: Thu Apr 17 2025 - 01:54:26 EST


On Wed, Apr 16, 2025 at 08:29:33PM GMT, Ivan Vecera wrote:
> On Wed, Apr 16, 2025 at 7:42 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
> >
> >
> > On Wed, 16 Apr 2025 18:21:38 +0200, Ivan Vecera wrote:
> > > Add DT bindings for Microchip Azurite DPLL chip family. These chips
> > > provides up to 5 independent DPLL channels, 10 differential or
> > > single-ended inputs and 10 differential or 20 single-ended outputs.
> > > It can be connected via I2C or SPI busses.
> > >
> > > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> > > ---
> > > v1->v3:
> > > * single file for both i2c & spi
> > > * 5 compatibles for all supported chips from the family
> > > ---
> > > .../bindings/dpll/microchip,zl30731.yaml | 115 ++++++++++++++++++
> > > 1 file changed, 115 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
> > $id: http://devicetree.org/schemas/dpll/microchip,zl3073x.yaml
>
> Oops, my bad... I forgot to update $id after rename of the file...
> Will fix.

No, you forgot to test. You are expected to build your code (and this is
here testing) BEFORE you post, not after or not through community
resources.