Re: [PATCH net] net: txgbe: fix memory leak in txgbe_probe() error path

[Simon Horman]

On Tue, Apr 15, 2025 at 08:59:09AM +0530, Abdun Nihaal wrote:
> When txgbe_sw_init() is called, memory is allocated for wx->rss_key
> in wx_init_rss_key(). However, in txgbe_probe() function, the subsequent
> error paths after txgbe_sw_init() don't free the rss_key. Fix that by
> freeing it in error path along with wx->mac_table.
> 
> Also change the label to which execution jumps when txgbe_sw_init()
> fails, because otherwise, it could lead to a double free for rss_key,
> when the mac_table allocation fails in wx_sw_init().
> 
> Fixes: 937d46ecc5f9 ("net: wangxun: add ethtool_ops for channel number")
> Reported-by: Jiawen Wu <jiawenwu@xxxxxxxxxxxxxx>
> Signed-off-by: Abdun Nihaal <abdun.nihaal@xxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>