Re: [PATCH next] drm/udl: Set error code in udl_init()

[Thomas Zimmermann]

Hi,

thanks for the fix.

Am 16.04.25 um 13:09 schrieb Dan Carpenter:
> Return -ENOMEM if udl_alloc_urb_list() fails.  Don't return success.
>
> Fixes: fb10144ba426 ("drm/udl: Support adapters without firmware descriptor")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

> ---
>   drivers/gpu/drm/udl/udl_main.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index 3dfeb88cf918..bc58991a6f14 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -361,6 +361,7 @@ int udl_init(struct udl_device *udl)
>   
>   	if (!udl_alloc_urb_list(udl, WRITES_IN_FLIGHT, MAX_TRANSFER)) {
>   		DRM_ERROR("udl_alloc_urb_list failed\n");
> +		ret = -ENOMEM;
>   		goto err;
>   	}
>   

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)