RE: [PATCH v5 net-next 04/14] net: enetc: add MAC filtering for i.MX95 ENETC PF

[Wei Fang]

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: 2025年4月16日 11:43
> To: Wei Fang <wei.fang@xxxxxxx>
> Cc: Claudiu Manoil <claudiu.manoil@xxxxxxx>; Vladimir Oltean
> <vladimir.oltean@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>;
> andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; christophe.leroy@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 net-next 04/14] net: enetc: add MAC filtering for i.MX95
> ENETC PF
> 
> On Fri, 11 Apr 2025 17:57:42 +0800 Wei Fang wrote:
> >  	enetc4_pf_netdev_destroy(si);
> >  	enetc4_pf_free(pf);
> > +	destroy_workqueue(si->workqueue);
> 
> I think that you need to flush or cancel the work after unregistering
> the netdev but before freeing it? The work may access netdev after its
> freed.

Yes, you are right, I will improve it. thanks.