Re: [PATCH] btrfs: zstd: add `zstd-fast` alias mount option for fast modes

From: David Sterba
Date: Tue Apr 15 2025 - 13:02:46 EST


On Tue, Apr 15, 2025 at 01:20:15PM +0930, Qu Wenruo wrote:
> 在 2025/4/14 16:23, Daniel Vacek 写道:
> > On Wed, 2 Apr 2025 at 16:31, Daniel Vacek <neelx@xxxxxxxx> wrote:
> [...]
> >> I'd still opt for keeping full range and functionality including
> >> negative levels using the plain `zstd:N` option and having the other
> >> just as an additional alias (for maybe being a bit nicer to some
> >> humans, but not a big deal really and a matter of preference).
> >> Checking the official documentation, it still mentions "negative
> >> compression levels" being the fast option.
> >>
> >> https://facebook.github.io/zstd/
> >> https://facebook.github.io/zstd/zstd_manual.html
> >>
> >> The deprecation part looks like just some gossip. It looks more about
> >> the cli tool api and we are defining a kernel mount api - perfectly
> >> unrelated.
> >
> > Any feedback, Dave? I tend to drop this ida of `zstd-fast` alias.
>
> Not Dave here, but if the future of "zstd-fast" is not that clear, we
> can definitely wait for a while.
>
> It's always safer to adapt when the terminology is mature enough.

Thanks all for the feedback, OK let's put it on hold.