Re: [PATCH v2] PCI: fix the printed delay amount in info print

From: Ilpo Järvinen
Date: Mon Apr 14 2025 - 09:01:57 EST


On Mon, 14 Apr 2025, Wilfred Mallawa wrote:

> From: Wilfred Mallawa <wilfred.mallawa@xxxxxxx>
>
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
>
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait time for slow links")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@xxxxxxx>
> Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..8139b70cafa9 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
> delay);
> if (!pcie_wait_for_link_delay(dev, true, delay)) {
> /* Did not train, no need to wait any further */
> - pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
> + pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
> return -ENOTTY;
> }
>
>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.