Re: [PATCH v3 3/3] drm: panel: Add driver for Himax HX8279 DDIC panels

[AngeloGioacchino Del Regno]

Il 11/04/25 10:51, neil.armstrong@xxxxxxxxxx ha scritto:
> On 10/04/2025 09:24, AngeloGioacchino Del Regno wrote:
> > Add a driver for the Himax HX8279-D MIPI-DSI DriverIC with support
> > for the Startek KX070FHFID078 7.0" 1200x1920 IPS panel, found on
> > various MediaTek Genio Evaluation Kit boards and for the Aoly
> > SL101PM1794FOG-v15 10.1" 1200x1920 LCD panel found on some I.MX8MM
> > boards.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/panel/Kconfig              |   11 +
> >   drivers/gpu/drm/panel/Makefile             |    1 +
> >   drivers/gpu/drm/panel/panel-himax-hx8279.c | 1365 ++++++++++++++++++++
> >   3 files changed, 1377 insertions(+)
> >   create mode 100644 drivers/gpu/drm/panel/panel-himax-hx8279.c
> >
> > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> > index e059b06e0239..42bc6097bf10 100644
> > --- a/drivers/gpu/drm/panel/Kconfig
> > +++ b/drivers/gpu/drm/panel/Kconfig
> > @@ -154,6 +154,17 @@ config DRM_PANEL_LVDS
> >         handling of power supplies or control signals. It implements automatic
> >         backlight handling if the panel is attached to a backlight controller.
> > +config DRM_PANEL_HIMAX_HX8279
> > +    tristate "Himax HX8279-based panels"
> > +    depends on OF
> > +    depends on DRM_MIPI_DSI
> > +    depends on BACKLIGHT_CLASS_DEVICE
> > +    help
> > +      Say Y if you want to enable support for panels based on the
> > +      Himax HX8279 controller, such as the Startek KD070FHFID078
> > +      7.0" 1200x1920 IPS LCD panel that uses a MIPI-DSI interface
> > +      and others.
> > +
> >   config DRM_PANEL_HIMAX_HX83102
> >       tristate "Himax HX83102-based panels"
> >       depends on OF
> > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> > index 1bb8ae46b59b..4fded6e66b05 100644
> > --- a/drivers/gpu/drm/panel/Makefile
> > +++ b/drivers/gpu/drm/panel/Makefile
> > @@ -16,6 +16,7 @@ obj-$(CONFIG_DRM_PANEL_EBBG_FT8719) += panel-ebbg-ft8719.o
> >   obj-$(CONFIG_DRM_PANEL_ELIDA_KD35T133) += panel-elida-kd35t133.o
> >   obj-$(CONFIG_DRM_PANEL_FEIXIN_K101_IM2BA02) += panel-feixin-k101-im2ba02.o
> >   obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o
> > +obj-$(CONFIG_DRM_PANEL_HIMAX_HX8279) += panel-himax-hx8279.o
> >   obj-$(CONFIG_DRM_PANEL_HIMAX_HX83102) += panel-himax-hx83102.o
> >   obj-$(CONFIG_DRM_PANEL_HIMAX_HX83112A) += panel-himax-hx83112a.o
> >   obj-$(CONFIG_DRM_PANEL_HIMAX_HX8394) += panel-himax-hx8394.o
> > diff --git a/drivers/gpu/drm/panel/panel-himax-hx8279.c b/drivers/gpu/drm/panel/ 
> > panel-himax-hx8279.c
> > new file mode 100644
> > index 000000000000..72bddba2663f
> > --- /dev/null
> > +++ b/drivers/gpu/drm/panel/panel-himax-hx8279.c
> > @@ -0,0 +1,1365 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Himax HX8279 DriverIC panels driver
> > + *
> > + * Copyright (c) 2025 Collabora Ltd.
> > + *                    AngeloGioacchino Del Regno 
> > <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > + */
> > +

..snip..

> Thanks for this very nice driver, very well documented an clean :-)
>
> Some bits to change for the dsi_multi handling, but overall very good!

Thanks to you for the review! :-)

Sending a v4 in 3..2..1...

Cheers,
Angelo

> Neil