Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc`

From: Christian Schrefl
Date: Sat Apr 12 2025 - 09:56:00 EST


On 12.04.25 1:59 PM, Miguel Ojeda wrote:
> On Sat, Apr 12, 2025 at 12:30 PM Christian Schrefl
> <chrisi.schrefl@xxxxxxxxx> wrote:
>>
>> "propper" type for this, so use a `*const kernel::ffi::c_char` pointer
>> instad.
>
> A couple typos -- I usually suggest using e.g. `scripts/checkpatch.pl
> --codespell`.
Do you want me to send a v3 with that fixed or are you going to do that
when applying.

(I've now configured my `b4 check` to add `--codespell`)

>
>> This should probably be backported to stable, for people/distros
>> using Arm 32 patches on stable.
>
> Up to the stable team -- I will add Cc: stable when I pick it up since
> it shouldn't hurt, but it does not change anything there for the
> supported arches, so they may or may not want to pick it.
>
> Thanks!
>
> Cheers,
> Miguel