Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h

[Mario Limonciello]

On 4/11/25 06:49, Borislav Petkov wrote:
> On Thu, Apr 10, 2025 at 03:02:00PM -0500, Mario Limonciello wrote:
> > From: Mario Limonciello <mario.limonciello@xxxxxxx>
> >
> > SB800_PIIX4_FCH_PM_ADDR is used to indicate the base address for the
> > FCH PM registers.  Multiple drivers may need this base address, so
> > move it to a common header location and rename accordingly.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> > ---
> >   arch/x86/include/asm/amd_node.h |  2 ++
> >   drivers/i2c/busses/i2c-piix4.c  | 12 ++++++------
> >   2 files changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/amd_node.h b/arch/x86/include/asm/amd_node.h
> > index 23fe617898a8f..f4993201834ea 100644
> > --- a/arch/x86/include/asm/amd_node.h
> > +++ b/arch/x86/include/asm/amd_node.h
> > @@ -19,6 +19,8 @@
> >   
> >   #include <linux/pci.h>
> >   
> > +#define FCH_PM_BASE		0xFED80300
>
> Is that even related to amd_node?
>
> Or should it be in some x86...platform.h header?

I was aiming for a header that we would conceivably use in all these 
places anyway.

Can you suggest a more fitting existing header?  A new one felt too 
heavy for a single register define.