Re: [tip: objtool/urgent] objtool: Fix false-positive "ignoring unreachables" warning

From: Josh Poimboeuf
Date: Thu Apr 10 2025 - 15:13:58 EST


On Thu, Apr 10, 2025 at 06:14:43AM +0000, tip-bot2 for Josh Poimboeuf wrote:
> The following commit has been merged into the objtool/urgent branch of tip:
>
> Commit-ID: 8af6f0fe9c4340ed97f0ba4f3f6cc7bb16558e87
> Gitweb: https://git.kernel.org/tip/8af6f0fe9c4340ed97f0ba4f3f6cc7bb16558e87
> Author: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> AuthorDate: Wed, 09 Apr 2025 15:49:36 -07:00
> Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitterDate: Thu, 10 Apr 2025 08:03:05 +02:00
>
> objtool: Fix false-positive "ignoring unreachables" warning
>
> There's no need to try to automatically disable unreachable warnings if
> they've already been manually disabled due to CONFIG_KCOV quirks.
>
> This avoids a spurious warning with a KCOV kernel:
>
> fs/smb/client/cifs_unicode.o: warning: objtool: cifsConvertToUTF16.part.0+0xce5: ignoring unreachables due to jump table quirk
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/5eb28eeb6a724b7d945a961cfdcf8d41e6edf3dc.1744238814.git.jpoimboe@xxxxxxxxxx
>
> Closes: https://lore.kernel.org/r/202504090910.QkvTAR36-lkp@xxxxxxxxx/

Superfluous newline there.

Also, this probably could use a fixes tag:

Fixes: eeff7ac61526 ("objtool: Warn when disabling unreachable warnings")

Thanks!

--
Josh