Re: [PATCH v14 1/3] dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series

From: Inochi Amaoto
Date: Thu Apr 10 2025 - 01:45:47 EST


On Sat, Mar 15, 2025 at 11:49:12PM +0100, Alexander Sverdlin wrote:
> From: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
>
> Add RTC devicetree binding for Sophgo CV1800 series SoC. The device is
> called RTC, but contains control registers of other HW blocks in its
> address space, most notably of Power-on-Reset (PoR) module, DW8051 IP
> (MCU core), accompanying SRAM, hence putting it in SoC subsystem.
>
> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> Changelog:
> v14:
> - no changes
> v13:
> - Moved bindings from MFD into SOC subsystem
>
> v12:
> - maintainer Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> -> sophgo@xxxxxxxxxxxxxxx
> - dropped Reviewed-by: Krzysztof Kozlowski
> - link to TRM
> - mentioned 8051 core in the description
> - binding is now MFD, not RTC
> - added "syscon" compatible
> - added "interrupt-names", "clock-names" (because of added PM/remoteproc)
> - main compatible "sophgo,cv1800-rtc" -> "sophgo,cv1800b-rtc"
>
> .../soc/sophgo/sophgo,cv1800b-rtc.yaml | 86 +++++++++++++++++++
> 1 file changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml

LGTM.

Reviewed-by: Inochi Amaoto <inochiama@xxxxxxxxx>