Re: [PATCH v8 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping

From: Samuel Abraham
Date: Wed Apr 09 2025 - 04:54:27 EST


On Wed, Apr 9, 2025 at 3:11 AM Julia Lawall <julia.lawall@xxxxxxxx> wrote:
>
>
>
> On Tue, 8 Apr 2025, Samuel Abraham wrote:
>
> > On Tue, Apr 8, 2025 at 8:41 PM Andy Shevchenko <andy@xxxxxxxxxx> wrote:
> > >
> > > On Tue, Apr 08, 2025 at 03:41:55PM +0000, Abraham Samuel Adekunle wrote:
> > > > The patchset adds spaces around binary operators, breaks long lines to enhance readability
> > > > and provides clarity on sequence number wrapping by using a modulo operation % 4096u, in
> > > > place of the bitwise AND(&) operation & 0xfff.
> > > > The patches are required to be applied in sequence.
> > >
> > > You missed my tags I gave in a previous review round.
> >
> > Oh, I'm sorry I do not know how that works, please.
> > Am I supposed to add them to the commit message?
>
> Yes.

Hello Julia.
Thanks for the clarity

Adekunle