Re: [PATCH 2/2] fuse: Adjust readdir() buffer to requesting buffer size.

From: Jaco Kroon
Date: Wed Apr 09 2025 - 03:12:49 EST


Hi Bernd,

You sure you're looking at the newest version?

Or where does the below need to get applied?

I'm not seeing that in the patch to which you replied.

Kind regards,
Jaco


On 2025/04/08 16:19, Bernd Schubert wrote:


On 4/1/25 17:33, Miklos Szeredi wrote:
On Tue, 1 Apr 2025 at 17:04, Jaco Kroon <jaco@xxxxxxxxx> wrote:

Because fuse_simple_request via fuse_args_pages (ap) via fuse_io_args
(ia) expects folios and changing that is more than what I'm capable off,
and has larger overall impact.
Attaching a minimally tested patch.
Just tested this and looks good to me. Could we change to

- size_t bufsize = 131072;
+ size_t bufsize = fc->max_pages << PAGE_SHIFT;

?

I'm testing with that in my branch, going to run xfstests over night.


Reviewed-by: Bernd Schubert <bschubert@xxxxxxx>


Thanks,
Bernd