Re: [PATCH 1/3] rust: dma: be consistent in using the `coherent` nomenclature
From: Andreas Hindborg
Date: Tue Apr 08 2025 - 08:45:52 EST
"Abdiel Janulgue" <abdiel.janulgue@xxxxxxxxx> writes:
> In the kernel, `consistent` and `coherent` are used interchangeably for
> the region described in this api. Stick with `coherent` nomenclature
> to show that dma_alloc_coherent() is being used.
>
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxx>
> ---
> rust/kernel/dma.rs | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs
> index 8cdc76043ee7..d3f448868457 100644
> --- a/rust/kernel/dma.rs
> +++ b/rust/kernel/dma.rs
> @@ -89,15 +89,15 @@ pub mod attrs {
> /// Forces contiguous allocation of the buffer in physical memory.
> pub const DMA_ATTR_FORCE_CONTIGUOUS: Attrs = Attrs(bindings::DMA_ATTR_FORCE_CONTIGUOUS);
>
> - /// This is a hint to the DMA-mapping subsystem that it's probably not worth the time to try
> + /// Hints DMA-mapping subsystem that it's probably not worth the time to try
This and the next two edits has nothing to do with coherent/consistent
nomenclature. Please update the commit message to reflect that.
Best regards,
Andreas Hindborg