Re: [PATCH v8 1/2] acpi/ghes, cxl/pci: Process CXL CPER Protocol Errors

[Li Ming]

On 3/11/2025 6:38 AM, Smita Koralahalli wrote:
> When PCIe AER is in FW-First, OS should process CXL Protocol errors from
> CPER records. Introduce support for handling and logging CXL Protocol
> errors.
>
> The defined trace events cxl_aer_uncorrectable_error and
> cxl_aer_correctable_error trace native CXL AER endpoint errors. Reuse them
> to trace FW-First Protocol errors.
>
> Since the CXL code is required to be called from process context and
> GHES is in interrupt context, use workqueues for processing.
>
> Similar to CXL CPER event handling, use kfifo to handle errors as it
> simplifies queue processing by providing lock free fifo operations.
>
> Add the ability for the CXL sub-system to register a workqueue to
> process CXL CPER protocol errors.
>
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@xxxxxxx>
> ---
[snip]
> +int cxl_ras_init(void)
> +{
> +	int rc;
> +
> +	rc = cxl_cper_register_prot_err_work(&cxl_cper_prot_err_work);
> +
> +	return rc;
> +}

Just one minor comment.

This rc is not needed, can return cxl_cper_register_prot_err_work() directly.


Reviewed-by: Li Ming <ming.li@xxxxxxxxxxxx>