Re: [PATCH v4 0/5] Add support for the TPM FF-A start method

[Stuart Yoder]

On 3/4/25 10:02 AM, Jarkko Sakkinen wrote:
> On Mon, 2025-03-03 at 12:55 -0400, Jason Gunthorpe wrote:
> > On Sun, Mar 02, 2025 at 09:33:59PM +0200, Jarkko Sakkinen wrote:
> > > WARNING: line length of 102 exceeds 100 columns
> > > #764: FILE: drivers/char/tpm/tpm_crb.c:821:
> > > +                              FW_BUG "TPM2 ACPI table has wrong
> > > size %u for start method type %d\n",
> >
> > Just ignore that, it is an error in checkpatch. Strings are required
> > to
> > be long. I suspect FW_BUG confused it.
>
> Yep, as its own issue I think you are right.
>
> I also noticed couple of additional style issues not picked
> by checkpatch:
>
> 	if (rc == -ENOENT) {  // FF-A driver is not available yet
> 		rc = -EPROBE_DEFER;
> 	}
>
> I.e. extra curly braces and "//" comment.
>
> Should be:
>
> 	/* If driver is not available yet, request probe retry: */
> 	if (rc == -ENOENT)
> 		rc = -EPROBE_DEFER;

I will respin and fix this.

Thanks,
Stuart