Re: [PATCH v2 0/4] tools/nolibc: MIPS: entrypoint cleanups and N32/N64 ABIs
From: Thomas Weißschuh
Date: Sat Mar 01 2025 - 10:52:45 EST
On 2025-03-01 15:47:52+0000, Maciej W. Rozycki wrote:
> On Sat, 1 Mar 2025, Willy Tarreau wrote:
>
> > > Introduce support for the N32 and N64 ABIs. As preparation, the
> > > entrypoint is first simplified significantly. Thanks to Maciej for all
> > > the valuable information.
> > >
> > > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > > ---
> > > Changes in v2:
> > > - Clean up entrypoint first
> > > - Annotate #endifs
> > > - Link to v1: https://lore.kernel.org/r/20250212-nolibc-mips-n32-v1-1-6892e58d1321@xxxxxxxxxxxxxx
> >
> > OK I tested this series on my glinet (MIPS 24Kc, XARCH=mips32be) and
> > it worked fine, confirming that the stack alignments were not needed
> > and that the cleanup is quite welcome!
>
> I do hope it can wait two weeks until I'm back from my holiday.
Absolutely.
> I mean
> to double-check the code visually and verify it with my R3000 and R4000
> hardware (the latter for n64/n32 too), both of which are less forgiving
> when it comes to instruction scheduling (I can check with a 74Kf too).
Your testing and feedback is very valuable, I'm happy to wait for it.
Thanks,
Thomas