[PATCH v4 2/2] power: reset: nvmem-reboot-mode: support smaller magic

From: Jennifer Berringer
Date: Fri Feb 28 2025 - 13:05:24 EST


Some devices, such as Qualcomm sa8775p, have an nvmem reboot mode cell
that is only 1 byte, which resulted in nvmem_reboot_mode_write() failing
when it attempts to write a 4-byte magic. Checking the nvmem cell size
and writing only the lower bits of the reboot mode magic is needed for
these devices.

Signed-off-by: Jennifer Berringer <jberring@xxxxxxxxxx>
---
drivers/power/reset/nvmem-reboot-mode.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/power/reset/nvmem-reboot-mode.c b/drivers/power/reset/nvmem-reboot-mode.c
index 41530b70cfc4..112e6cf77d1b 100644
--- a/drivers/power/reset/nvmem-reboot-mode.c
+++ b/drivers/power/reset/nvmem-reboot-mode.c
@@ -20,11 +20,18 @@ static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot,
unsigned int magic)
{
int ret;
+ u8 *magic_ptr = (u8 *) &magic;
+ size_t cell_size;
struct nvmem_reboot_mode *nvmem_rbm;

nvmem_rbm = container_of(reboot, struct nvmem_reboot_mode, reboot);
+ cell_size = nvmem_cell_size(nvmem_rbm->cell);

- ret = nvmem_cell_write(nvmem_rbm->cell, &magic, sizeof(magic));
+ /* Use magic's low-order bytes when writing to a smaller cell. */
+ if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) && cell_size < sizeof(magic))
+ magic_ptr += sizeof(magic) - cell_size;
+
+ ret = nvmem_cell_write(nvmem_rbm->cell, magic_ptr, MIN(cell_size, sizeof(magic)));
if (ret < 0)
dev_err(reboot->dev, "update reboot mode bits failed\n");

--
2.47.1