Re: [PATCH v2 2/2] igc: Trigger proper interrupts in igc_xsk_wakeup
From: Tony Nguyen
Date: Thu Apr 21 2022 - 16:24:29 EST
On 4/19/2022 6:26 PM, jeff.evanson@xxxxxxxxx wrote:
From: Jeff Evanson <jeff.evanson@xxxxxxx>
In igc_xsk_wakeup, trigger the proper interrupt based on whether flags
contains XDP_WAKEUP_RX and/or XDP_WAKEUP_TX.
Consider a scenario where the transmit queue interrupt is mapped to a
different irq from the receive queue. If XDP_WAKEUP_TX is set in the
flags argument, the interrupt for transmit queue must be triggered,
otherwise the transmit queue's napi_struct will never be scheduled.
In the case where both XDP_WAKEUP_TX and XDP_WAKEUP_RX are both set,
the receive interrupt should always be triggered, but the transmit
interrupt should only be triggered if its q_vector differs from the
receive queue's interrupt.
Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy")
You're missing your sign-off; same for patch 1. Also, there's a handful
of issues being reported by checkpatch [1]
Thanks,
Tony
[1]
https://patchwork.kernel.org/project/netdevbpf/patch/20220420012635.13733-3-jeff.evanson@xxxxxxx/